[MPlayer-cvslog] r33168 - trunk/gui/skin/skin.c

[Diego Biurrun]

On Thu, Mar 31, 2011 at 12:56:42PM +0200, ib wrote:
> 
> Log:
> (Almost entirely) cosmetic:

This should ring an alarm in your head that you have set yourslf a trap
and are about to step into it.

> In setname() path is now completely received from skinfname.

Hmmmm....

> --- trunk/gui/skin/skin.c	Thu Mar 31 12:13:47 2011	(r33167)
> +++ trunk/gui/skin/skin.c	Thu Mar 31 12:56:42 2011	(r33168)
> @@ -851,41 +851,41 @@ static _item skinItem[] = {
>  
> -    av_strlcpy(path, fn, sizeof(path));
> +    av_strlcat(skinfname, "/", sizeof(skinfname));
> -    av_strlcat(path, "/", sizeof(path));
> +    av_strlcpy(path, skinfname, sizeof(path));
> -    av_strlcat(fn, "/skin", sizeof(fn));
> +    av_strlcat(skinfname, "skin", sizeof(skinfname));

... this change?  It's very well hidden in the noise.  Please don't do that.

Diego