[MPlayer-cvslog] r32180 - trunk/libmpcodecs/vf_ass.c

[Diego Biurrun]

On Fri, Sep 17, 2010 at 06:06:42PM +0200, Reimar Döffinger wrote:
> On Fri, Sep 17, 2010 at 05:18:21PM +0200, Diego Biurrun wrote:
> > On Sun, Sep 12, 2010 at 04:03:00PM +0200, Reimar Döffinger wrote:
> > > On Sun, Sep 12, 2010 at 01:22:42PM +0200, diego wrote:
> > > > 
> > > > Log:
> > > > cosmetics: Reformat in K&R style, prettyprinting.
> > > 
> > > Could you please do whitespace and newline changes independently?
> > > Like this it's quite annoying to look through even with diff -w
> > 
> > Actually, that would be a major annoyance..
> 
> Maybe it can be automated?
> Maybe even something crazy like a keyword in the commit
> message that makes svn send such a reduced diff (only or in addition)?

It could be done, but how about ..

> > Do you have a problem with the output from 'svn diff -x -uwb'?
> > I find this quite readable and it reduces the burden of splitting
> > such commits...
> 
> In principle I have these problems
> 1) Basically nobody will go to the effort, so such changes are
>    mostly or completely unreviewed.
> 2) I cannot review it on a non-development machine
> 3) If I have objections quoting it is an annoyance
> 
> 2) and 3) are basically the same thing, it is not compatible
> with an email-based review method.

.. just sending the output of 'svn diff -x -uwb' to the list manually?

Diego