[MPlayer-cvslog] r32230 - trunk/configure

[Reimar Döffinger]

On Wed, Sep 15, 2010 at 04:09:15PM +0200, Diego Biurrun wrote:
> On Tue, Sep 14, 2010 at 08:28:53PM +0200, Reimar Döffinger wrote:
> > On Tue, Sep 14, 2010 at 11:47:08AM +0200, diego wrote:
> > > 
> > > Log:
> > > Fix parameter types in swab() check; fixes the warnings:
> > > tmp.c:3: warning: null argument where non-null required (argument 1)
> > > tmp.c:3: warning: null argument where non-null required (argument 2)
> > > 
> > > --- trunk/configure	Tue Sep 14 11:45:40 2010	(r32229)
> > > +++ trunk/configure	Tue Sep 14 11:47:08 2010	(r32230)
> > > @@ -3932,7 +3932,7 @@ echocheck "swab()"
> > >  cat > $TMPC << EOF
> > >  #define _XOPEN_SOURCE 600
> > >  #include <unistd.h>
> > > -int main(void) { swab(0, 0, 0); return 0; }
> > > +int main(void) { swab(NULL, NULL, 0); return 0; }
> > 
> > If that "fixes" those warnings, that's a compiler bug.
> 
> Somehow I fumbled looking at config.log or whatever, the warnings are
> still there:
> 
> tmp.c:3: warning: null argument where non-null required (argument 1)
> tmp.c:3: warning: null argument where non-null required (argument 2)
> 
> In any case, it's no worse than before, so I'm leaving it...

Well, I'd be careful with that kind of changes, because I don't
know if unistd.h is _required_ to define NULL, if not this might
break compilation on some systems.
A mismatching commit message isn't good either way.