[MPlayer-cvslog] r32163 - trunk/udp_sync.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Sep 12 08:55:30 CEST 2010


On Sun, Sep 12, 2010 at 12:12:41AM +0200, diego wrote:
> Author: diego
> Date: Sun Sep 12 00:12:41 2010
> New Revision: 32163
> 
> Log:
> Add #include for required header mp_core.h; fixes 'make checkheaders'.

It only fixes a warning.

> @@ -31,6 +33,6 @@ extern const char *udp_ip; // where the 
>  extern float udp_seek_threshold; // how far off before we seek
>  
>  void send_udp(const char *send_to_ip, int port, char *mesg);
> -int udp_slave_sync(struct MPContext *mpctx);
> +int udp_slave_sync(MPContext *mpctx);

That is a bad idea, we always should use the struct... variant
in headers, we should not needlessly make it hard to make
structs opaque (which btw. should have been done in spudec.c
instead of using void * everywhere).


More information about the MPlayer-cvslog mailing list