[MPlayer-cvslog] r32072 - trunk/udp_sync.h

[Diego Biurrun]

On Thu, Sep 09, 2010 at 10:37:50PM +0200, Reimar Döffinger wrote:
> On Thu, Sep 09, 2010 at 05:49:24PM +0200, Diego Biurrun wrote:
> > > What do you think about this warning?
> > > Should we try to disable it, should I add a
> > > struct MPContext;
> > > to that header or re-add the include?
> > 
> > Readd the #include.
> > 
> > > I'd rather have such tiny headers not include other rather huge ones.
> > 
> > If you worry about header size, reduce the size of the headers you
> > worry about.  However, headers should work standalone and #include
> > all of their dependencies, no matter how large.
> 
> It does work just fine stand-alone, there's just a (IMO) rather silly
> gcc warning.

I will readd the #include.  I'm still convinced it is the best solution.

Diego