[MPlayer-cvslog] r32072 - trunk/udp_sync.h

[Diego Biurrun]

On Thu, Sep 09, 2010 at 07:07:04AM +0200, Reimar Döffinger wrote:
> On Wed, Sep 08, 2010 at 09:15:44PM +0200, Diego Biurrun wrote:
> > On Wed, Sep 08, 2010 at 07:47:54PM +0200, reimar wrote:
> > > 
> > > Log:
> > > Remove useless include.
> > > 
> > > --- trunk/udp_sync.h	Wed Sep  8 19:47:26 2010	(r32071)
> > > +++ trunk/udp_sync.h	Wed Sep  8 19:47:54 2010	(r32072)
> > > @@ -22,8 +22,6 @@
> > >  
> > > -#include "mp_core.h"
> > 
> > This was not useless, but necessary for MPContext, which is used below.
> 
> Fixed, however now results in
> udp_sync.h:34: warning: 'struct MPContext' declared inside parameter list
> udp_sync.h:34: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> What do you think about this warning?
> Should we try to disable it, should I add a
> struct MPContext;
> to that header or re-add the include?

Readd the #include.

> I'd rather have such tiny headers not include other rather huge ones.

If you worry about header size, reduce the size of the headers you
worry about.  However, headers should work standalone and #include
all of their dependencies, no matter how large.

Diego