[MPlayer-cvslog] r32047 - trunk/mplayer.c

[Reynaldo H. Verdejo Pinochet]

Hi

Diego Biurrun wrote:
> On Sat, Sep 04, 2010 at 09:24:34PM +0200, reynaldo wrote:
>> Log:
>> Cosmetics
> 
> Note that I don't think splitting cosmetics commits is worth it.
> 
>> --- trunk/mplayer.c	Sat Sep  4 21:09:23 2010	(r32046)
>> +++ trunk/mplayer.c	Sat Sep  4 21:24:34 2010	(r32047)
>> @@ -3223,14 +3223,16 @@ while (player_idle_mode && !filename) {
>>  
>> +    if (edl_output_filename) {
>> +        if (edl_fd)
>> +            fclose(edl_fd);
>> +        if ((edl_fd = fopen(edl_output_filename, "w")) == NULL)
>> +        {
> 
> If you are changing the line anyway, you might as well fix brace
> placement.

OK.

> 
>> +            mp_msg(MSGT_CPLAYER, MSGL_ERR, MSGTR_EdlCantOpenForWrite,
>> +                    filename_recode(edl_output_filename));
> 
> Indentation is off.

Why do you think its off? That source section uses 4 spaces per
indentation level.

>> @@ -3994,13 +3996,14 @@ if(step_sec>0) {
>>                mp_msg(MSGT_CPLAYER, MSGL_ERR, MSGTR_EdlOutOfMemFile,
>> -                    cmd->args[0].v.s);
>> +                      cmd->args[0].v.s);
> 
> Indentation is off.

Its not off, that section uses a first indentation level at 2 spaces,
then 4 spaces for each one that follows.

> What editor do you use that allows you to fumble this type of
> indentation?

vim, no problem with that one I guess? using expandtab, tabstop and
shiftwidth 4 in my config for ages.

--
Reynaldo