[MPlayer-cvslog] r32035 - in branches/1.0rc4: . libmpdemux/demux_lavf.c

[Reimar Döffinger]

On Wed, Sep 01, 2010 at 11:36:47PM +0200, Aurelien Jacobs wrote:
> On Wed, Sep 01, 2010 at 06:22:27PM +0200, Reimar Döffinger wrote:
> > > Are you aware of anything else broken in lavf (mkv related) ?
> > 
> > There is a roundup issue on a webm test stream, but I haven't
> > even verified it is even valid.
> 
> Thanks for pointing to the issue and showing a possible fix !

Unfortunately the patch I sent does not fix anything at all :-(.
Well, at least it now detects it as unknown length, but it still
fails to parse it.

> > However, implementing "ASS parser take 3" in MPlayer isn't reasonable.
> 
> IMHO MPlayer shouldn't contain any single bit of ASS handling.
> Subtitle tracks should be decoded by lavc and rendered by lavfi...

Well, decoding by lavc might happen in a reasonable time, but
I wouldn't wait for lavfi :-)
Maybe you already looked at it, but it might be worth looking at the
SSA handling in subreader.c for the ASS -> text conversion.
While I'm sure it has its issues it still is well-tested code (though
GPL, so maybe I shouldn't recommend looking at it for writing a libavcodec
implementation...).