[MPlayer-cvslog] r32527 - in trunk: DOCS/man/de/mplayer.1 DOCS/man/en/mplayer.1 Makefile libmpcodecs/vf.c libmpcodecs/vf_stereo3d.c

[Reimar Döffinger]

On Sat, Oct 23, 2010 at 08:00:50PM +0200, Diego Biurrun wrote:
> On Fri, Oct 22, 2010 at 07:46:13PM +0200, reimar wrote:
> > 
> > Log:
> > Add stereo3d filter.
> > Further review very welcome, but it is time (and good enough) to add this.
> > Patch by Gordon Schmidt [gordon.schmidt s2000.tu-chemnitz de] with
> > changes by Endre Kollár [taxy443 gmail com].
> > 
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ trunk/libmpcodecs/vf_stereo3d.c	Fri Oct 22 19:46:12 2010	(r32527)
> > @@ -0,0 +1,478 @@
> > +
> > +extern int opt_screen_size_x;
> > +extern int opt_screen_size_y;
> 
> These need to go in an appropriate header.
> 
> I fought valiantly against extern variable declarations in .c files,
> please don't stab me in the back ;)

No worries, they already are in a header (I most likely would have noticed
if the variables themselves were new). Replaced by the proper include.