[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

[Reimar Döffinger]

On Sun, Oct 17, 2010 at 03:59:00PM +0200, Nicolas George wrote:
> Le sextidi 26 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> > "all out params may be NULL".
> 
> Not done, as it is not true. And since all the out params are necessary to
> do anything with the image, I do not think any effort to make it true would
> be worth it.

Sorry, I confused it with the other function. maxval is not really
necessary, but I agree it does not really make sense to make any optional.

> > And for bytes_per_pixel: "1 means 8 bit gray, 2 means 16 bit gray,
> > 3 means 8 bit/component RGB, 6 means 16 bit/component RGB."
> 
> Done.
> 
> As a side note, I believe that 16 bits support is broken on little-endian.
> But 16 bits PNM are non-standard anyway.

It is tested to work on little-endian (and only on that) within vo_gl with
files generated by GIMP.
And according to my man-pages they are not non-standard, and the MSB is
specified to come first.
So if you want you can add to the documentation that the data is in
little-endian format for the 16 bit formats (which means that the
feature is probably broken for vo_gl on big-endian machines -
big-endian machines with graphics cards that can do 16 bit texture
formats are a bit rare though, so hard to test...).