[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

[Reimar Döffinger]

On Sun, Oct 17, 2010 at 03:01:56PM +0200, Nicolas George wrote:
> Le sextidi 26 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> > I think it's ok. I'd appreciate if you could add a quick doxy to the .h
> > file for the pnm_read which I was too lazy to add.
> > Otherwise I'll try to remember to do it somewhen.
> 
> Done. It looks like this (the patch was huge because of the svn cp, I would
> rather avoid resending too many tumes):
> 
> /**
>  * Read a "portable anymap" image.
>  *  
>  * @param[in]  f                input stream.
>  * @param[out] width            width of the loaded image.
>  * @param[out] height           height of the loaded image.
>  * @param[out] bytes_per_pixel  format of the loaded image.
>  * @param[out] maxval           maximum pixel value.
>  * @return                      a newly allocated array of
>  *                              width*height*bytes_per_pixel bytes,
>  *                              or NULL in case of error.
>  */ 

No need to send that in for review, I can fix it if something is wrong.
Though you could add "supports raw pnm and pgm (P5 and P6)" and
"all out params may be NULL".
And for bytes_per_pixel: "1 means 8 bit gray, 2 means 16 bit gray,
3 means 8 bit/component RGB, 6 means 16 bit/component RGB."