[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

[Reimar Döffinger]

On Wed, Oct 13, 2010 at 11:54:47AM +0200, Nicolas George wrote:
> Le duodi 22 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> > Hm? If settings.changed is meant to indicate that the video properties
> > changed, I don't think it should be set on switching to another file.
> 
> My reasoning was: from the point of view of the sources that were just added
> or reset, the settings have really changed, since before that, they were
> nothing at all.
> 
> On the other hand, from the point of view of the other sources, a few
> extraneous cases where settings.changed is set should be no problem at all:
> after all, it happens if the user toggles the fullscreen by mistake or if
> what changed was a parameter they do not care about.

It means that the overhead of adding (even an empty) source suddenly becomes
the overhead of re-rendering all EOSD elements.

> And after all, "this is a new file" or "there is a new source" could
> reasonably be considered settings changes worthy of being reported, there is
> nothing absurd there.