[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

[Nicolas George]

Le primidi 21 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> Usually you shouldn't expect Diego to comment much on code correctness,
> you'd have to get someone else to review for that (unfortunately
> that usually means you'll have to get me to review).

Ok, that is duly noted.

> Actually keeping it is nicer for anything that is not file-specific
> subtitles.
> Strictly speaking this is something that might make sense as a
> per-source property, at least conceptually it would make sense
> to remove the ASS source, whereas for any kind of overlay 
> (e.g. a kind of newsticker) it makes more sense to keep.

That is a good idea, and it is not difficult to do at all. I will implement
it when the rest of this thread is done.

> I don't like the double-casts, but I'd say apply the patch fixing all.
> I realize it's an inconsistent mess anyway, but I'd say remove those four.

Committed.

> Just put it in root for now if you want.

Ok. That gives the attached patch, after a:

svn copy libvo/gl_common.c pnm_loader.c

I am not sure if keeping the history for such a tiny function in such a big
file was worth it.

I tested it still builds; I did not test it works since I do not know how
customtex is supposed to work, but I do not see what could cease to work.

> My suggestion is to name that dir sub/, because all these are
> related to subtitles (even though they are about more than subtitles).

That is still planned.

> Except mpbswap.h I don't think any of those are likely to have more than
> a single user, and as such should stay with the file that uses it.

Ok.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-pnmloader-20101014-1143.diff
Type: text/x-diff
Size: 78098 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20101014/6af6ff19/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20101014/6af6ff19/attachment-0001.pgp>