[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

[Reimar Döffinger]

On Wed, Oct 13, 2010 at 12:31:31AM +0200, Nicolas George wrote:
> Le primidi 21 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> > I understood your comment above to mean you checked that the source does get
> > emptied at some point though (would be ugly if subtitles carried on from
> > one file to the next).
> 
> The ASS source was properly reset, and subtitles do not stay from one file
> to the next. The overlay source, on the other hand, is not reset; I think
> this is a perfectly reasonable behaviour.

I agree. The only thing that I don't know if it's cleaner to reset or
to remove the source, but that's entirely up to you.

> Unfortunately, I stumbled on another problem I missed earlier when changing
> files: if the two files have exactly the same resolution, sources that rely
> on the settings.changed flag will not perform their initialization for the
> second file. The attached patch fixes it by setting the settings.changed
> flag when a source is added and when the system is reset.

Hm? If settings.changed is meant to indicate that the video properties
changed, I don't think it should be set on switching to another file.
Can you explain what kind of initialization those sources have to do
and why they can't figure out that they have to do it in some other way?