[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

[Nicolas George]

Le nonidi 19 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> Uh, this was never reviewed.

The first version got a few remarks from Diego that I took into account.

> Possible integer overflow.

Right. The one in gl_common does not have it.

> Is this certain to work correctly when playing multiple
> files?
> At least some subtitle stuff gets reset on each new file.
> If not, does the ASS stuff get correctly reset on a new file?

As said in my other mail, this one works, but there is a related bug which
causes a hang on file change; I submitted a patch to fix it.

In the current version, the list of EOSD sources is not emptied between
files. It could be, I have no strong feelings either way. Keeping it
requires slightly simpler code, while emptying it is maybe slightly more
logical.

> In general it might be nicer to have a function that checks
> if a particular source is already registered.

Done in the patch attached to my other mail.

> This will cause a warning on 64 bit.

Patch attached. Either fixing these two or also fixing the six ones that
were already there.

> Useless {}

I imitated from the two cases just above. Shall I remove only my two pairs,
or all four?


Le nonidi 19 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> I extracted the code in gl_common into a separate function,
> it just needs to go into some appropriate file.

I saw the commit, thanks.

Any preference about the place for the appropriate file? You recently said
that you did not like to have everything in the root directory. Maybe
misc_util/pnm_loader.c?

bstr.*, mpbswap.h, unrar_exec.*, gui/bitmap.*, libmpcodecs/cmmx.h could
possibly go there too.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-intptr.diff
Type: text/x-diff
Size: 848 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20101012/c2304aad/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-intptr2.diff
Type: text/x-diff
Size: 2743 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20101012/c2304aad/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20101012/c2304aad/attachment.pgp>