[MPlayer-cvslog] r32440 - trunk/etc/codecs.conf

[Diego Biurrun]

On Tue, Oct 05, 2010 at 03:59:21PM -0400, compn wrote:
> On Tue, 05 Oct 2010 15:19:30 +0200, Diego Biurrun wrote:
> >On Tue, Oct 05, 2010 at 06:38:15AM -0400, compn wrote:
> >> On Tue, 05 Oct 2010 09:40:04 +0200, Diego Biurrun wrote:
> >> >On Tue, Oct 05, 2010 at 03:01:15AM +0200, compn wrote:
> >> >> 
> >> >> Log:
> >> >> add another xdcam mpeg2 fourcc/isom
> >> >
> >> >Ahem...
> >> >
> >> >> --- trunk/etc/codecs.conf	Mon Oct  4 20:12:36 2010	(r32439)
> >> >> +++ trunk/etc/codecs.conf	Tue Oct  5 03:01:14 2010	(r32440)
> >> >> @@ -945,6 +945,7 @@ videocodec ffwmv3
> >> >>  
> >> >>  videocodec ffwmvp
> >> >>    info "FFmpeg WVC1"
> >> >> +  comment "requires demuxer lavf"
> >> >>    status buggy
> >> >>    fourcc wmvp,WMVP
> >> >>    driver ffmpeg
> >> >
> >> >... log message and diff do not match.
> >> >
> >> >This is not the first time.  Do you doublecheck by looking at diffs
> >> >before committing?
> >> 
> >> i missed it when looking at the diff. but i saw this while it was
> >> sending the commit to hq. doh.
> >
> >So you noticed your mistake but saw no necessity to fix it?
> 
> i couldnt remember if demuxer lavf was really required or not, i didnt
> have a way to test it until later.

Commit messages are important, not something that you add as an
afterthought and neglect.  Please place more importance on writing
correct and good commit messages.

Diego