[MPlayer-cvslog] r31233 - trunk/libmpdemux/demux_mkv.c

[Diego Biurrun]

On Sun, May 30, 2010 at 12:06:48AM +0200, Aurelien Jacobs wrote:
> On Thu, May 27, 2010 at 06:13:53PM +0200, diego wrote:
> > 
> > Log:
> > Remove two pointless void* casts.
> > 
> > --- trunk/libmpdemux/demux_mkv.c	Thu May 27 18:05:30 2010	(r31232)
> > +++ trunk/libmpdemux/demux_mkv.c	Thu May 27 18:13:53 2010	(r31233)
> > @@ -1963,14 +1963,13 @@ demux_mkv_open_audio (demuxer_t *demuxer
> >  
> >            sh_a->format = mmioFOURCC('f', 'L', 'a', 'C');
> > -          ptr = (unsigned char *) track->private_data
> > -            + sizeof (WAVEFORMATEX);
> > +          ptr = track->private_data + sizeof (WAVEFORMATEX);
> 
> This one was not pointless. Arithmetic with void pointer is undefined.
> This should generate a warning...

Yes, thanks for noticing, fixed.

While we're at it, there are still a bunch of other warnings :)

Diego