[MPlayer-cvslog] r30945 - in trunk: mpcommon.c mpcommon.h

Diego Biurrun diego at biurrun.de
Tue Mar 23 19:05:28 CET 2010


On Sun, Mar 21, 2010 at 11:13:00AM +0100, attila wrote:
> Author: attila
> Date: Sun Mar 21 11:13:00 2010
> New Revision: 30945
> 
> Log:
> 10l for Diego.

Please don't use such non-informative commit messages, especially in
the first line.  The first line should be a short description of your
change.

Please adjust this commit message.  Feel free to flame me in it, but
don't misuse the first line.

> Make all instances of codec_patch unconditional, otherwise
> compilation will break on systems that do not have win32 dlls
> enabled. Fixes compilation bug introduced by r30942
> 
> --- trunk/mpcommon.c	Sun Mar 21 09:34:09 2010	(r30944)
> +++ trunk/mpcommon.c	Sun Mar 21 11:13:00 2010	(r30945)
> @@ -314,7 +314,5 @@ const m_option_t noconfig_opts[] = {
>  
> -#ifdef CONFIG_WIN32DLL
>  char *codec_path = NULL;
> -#endif
>  
> --- trunk/mpcommon.h	Sun Mar 21 09:34:09 2010	(r30944)
> +++ trunk/mpcommon.h	Sun Mar 21 11:13:00 2010	(r30945)
> @@ -37,8 +37,6 @@ void set_osd_subtitle(subtitle *subs);
>  
> -#ifdef CONFIG_WIN32DLL
>  extern char *codec_path;
> -#endif

I found a better way to fix the problem, this code is no longer
necessary.

Diego


More information about the MPlayer-cvslog mailing list