[MPlayer-cvslog] r31410 - in trunk/loader/qtx: list.c qtxload.c

[Reimar Döffinger]

On Tue, Jun 15, 2010 at 12:05:00PM +0200, Attila Kinali wrote:
> On Mon, 14 Jun 2010 21:05:26 +0200
> Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> 
> > On Mon, Jun 14, 2010 at 01:45:33PM +0200, diego wrote:
> > > Author: diego
> > > Date: Mon Jun 14 13:45:33 2010
> > > New Revision: 31410
> > > 
> > > Log:
> > > Replace forward declarations by loader/wine/winbase.h #include.
> > 
> > Luckily it seems to work in this case, but the reason for that
> > kind of thing is that some of this code actually does not use
> > the loader/wine stuff but the Windows loader, and using those
> > includes can lead to conflicts between the Windows and the wine
> > headers.
> 
> I dont really get what you mean here. Do you mean that the code
> in question is a hack? Or that this commit is wrong because of
> the use of non-wine function under some conditions?

I mean:
A lot of code when compiled for MinGW includes windows.h
If windows.h and something from loader/wine/* is included at
the same time, compilation errors often result.
Thus, for any code that is also compiled when compiling for
MinGW you have to be careful about including things from
loader/wine because it might break compilation.
Also, being pedantic, when this code is compiled on MinGW it
would be slightly better if the declarations from the
Windows headers were used instead the wine ones.
But as said, it is fine, I just wanted to point out that
using the loader/wine/* headers can be quite tricky.