[MPlayer-cvslog] r31359 - in trunk: configure libmpcodecs/vd_libmpeg2.c libmpeg2/header.c libmpeg2/libmpeg2_changes.diff libmpeg2/slice.c

[Luca Barbato]

On 6/10/10 12:39 PM, Ivan Kalvachev wrote:
> It's good to discuss this kind of changes on the maillist not with one
> single developer, to avoid confusing situations like this.
>
> I am surprised that you fail to understand basic concepts like how
> postprocessing works and that you can't even test it properly.

That code from what I could see is DEAD CODE, if isn't then it will 
rewritten as an opaque pointer + callback.

> You need to insert postprocessing filter, like  pp, spp, fspp. The
> quant info is used by these filters. Also you for best results you
> need sample with less than perfect quality (aka with visible
> blocking).

I'll check now and see how much it does change. We might take this as an 
opportunity to document this requirement for vd (still I miss how this 
"quant info" would work with non-mpegish codecs that might have 
different parameters to describe it)

> Without way to export quantization, libmpeg2 is pretty much crippled.
>
> This functionality should be pushed upstream, so it could be
> implemented in cleaner standard way. Then it can be replaced.

Let's ask upstream IF is that compelling.

lu