[MPlayer-cvslog] r31305 - trunk/mplayer.c

[Reimar Döffinger]

On Wed, Jun 09, 2010 at 05:23:33PM +0200, Diego Biurrun wrote:
> On Wed, Jun 02, 2010 at 10:52:11PM +0200, Reimar Döffinger wrote:
> > On Wed, Jun 02, 2010 at 10:21:30PM +0200, cehoyos wrote:
> > > 
> > > Log:
> > > Fix compilation with external libass.
> > > 
> > > --- trunk/mplayer.c	Wed Jun  2 22:12:50 2010	(r31304)
> > > +++ trunk/mplayer.c	Wed Jun  2 22:21:29 2010	(r31305)
> > > @@ -2581,7 +2581,7 @@ static int seek(MPContext *mpctx, double
> > >  	vobsub_seek(vo_vobsub, mpctx->sh_video->pts);
> > >      }
> > >  
> > > -#ifdef CONFIG_ASS
> > > +#if defined(CONFIG_ASS_INTERNAL) || defined(LIBASS_VERSION) && LIBASS_VERSION > 0x00909000
> > 
> > It would be nicer to update the internal copy if someone wants :-)
> 
> I suggest we drop the internal copy instead...

My view is that the result will be users en up with an outdated distro version
(or no ASS support at all), report ancient bugs, then compile and install
a new version when told and then suddenly other applications don't work
because they ended up using the new version but only work with the distro version.
Which is a long form of: I think that would be a bad idea.