[MPlayer-cvslog] r31410 - in trunk/loader/qtx: list.c qtxload.c

[Diego Biurrun]

On Mon, Jul 05, 2010 at 09:07:50PM +0200, Reimar Döffinger wrote:
> On Mon, Jul 05, 2010 at 08:34:55PM +0200, Diego Biurrun wrote:
> > So what is the correct solution for vd_realvid.c and similar files?
> 
> That depends on which solution compiles.
> In principle: include the wine header for WIN32_LOADER, include windows.h
> for real Windows.
> 
> > Currently they use a bunch of forward declarations for stuff that is
> > declared in loader/wine/winbase.h (LoadLibraryA, GetProcAddress,
> > FreeLibrary, GetModuleHandleA), but the signature appears to be
> > somewhat incompatible.  If I replace the forward declarations by
> > the #include the result are a ton of warnings like
> > 
> > libmpcodecs/vd_realvid.c: In function 'load_syms_windows':
> > libmpcodecs/vd_realvid.c:184: warning: assignment makes pointer from integer without a cast
> > libmpcodecs/vd_realvid.c:191: warning: passing argument 1 of 'GetProcAddress' makes integer from pointer without a cast
> > libmpcodecs/vd_realvid.c:191: warning: assignment from incompatible pointer type
> 
> When you have the right includes, you should use the proper types,
> e.g. HANDLE instead of void * in some cases.

Beats me, it's a maze of typedefs and I think I know too little about
Windows programming.  I'll dedicate my time to other things.

Diego