[MPlayer-cvslog] r31601 - trunk/libvo/x11_common.c

reimar subversion at mplayerhq.hu
Thu Jul 1 21:48:00 CEST 2010


Author: reimar
Date: Thu Jul  1 21:48:00 2010
New Revision: 31601

Log:
Do not try to grab input from -wid windows, it will most likely break
their input processing.
If someone needs the previous behaviour, an option could be added
(and also used in the w32_common.c code).

Modified:
   trunk/libvo/x11_common.c

Modified: trunk/libvo/x11_common.c
==============================================================================
--- trunk/libvo/x11_common.c	Thu Jul  1 21:43:38 2010	(r31600)
+++ trunk/libvo/x11_common.c	Thu Jul  1 21:48:00 2010	(r31601)
@@ -1083,6 +1083,10 @@ void vo_x11_create_vo_window(XVisualInfo
       XInstallColormap(mDisplay, col_map);
     }
     if (WinID) vo_x11_update_geometry();
+    else
+        // Do not capture events since it might break the parent application
+        // if it relies on events being forwarded to the parent of WinID.
+        // It also is consistent with the w32_common.c code.
     vo_x11_selectinput_witherr(mDisplay, vo_window,
           StructureNotifyMask | KeyPressMask | PointerMotionMask |
           ButtonPressMask | ButtonReleaseMask | ExposureMask);


More information about the MPlayer-cvslog mailing list