[MPlayer-cvslog] r30256 - trunk/configure

[Reimar Döffinger]

On Sun, Jan 10, 2010 at 11:28:34PM +0100, bamiaux wrote:
> On 10/01/10 23:22, Reimar Döffinger wrote:
> >On Sun, Jan 10, 2010 at 10:48:52PM +0100, bamiaux wrote:
> >>On 10/01/10 21:57, Reimar Döffinger wrote:
> >>>On Sun, Jan 10, 2010 at 03:09:34PM -0500, compn wrote:
> >>>>On Sun, 10 Jan 2010 13:13:10 +0100 (CET), reimar wrote:
> >>>
> >>>Maybe someone using hwac3 could test attached patch.
> >>>The amount of code duplication seems still acceptable to me.
> >>
> >>I suggest the attached patch for ad_hwac3.c with reduced duplication.
> >
> >Problem is, this adds a dependency on libavcodec internals.
> >I'd prefer to make it not harder to link against external libavcodec
> >since distributions insist on doing that and they won't like us
> >for making their lives harder...
> >Am I missing something? Other opinions?
> 
> You're probably right, but:
> 
> libmpcodecs/vf_fspp.c:50:#include "libavutil/internal.h"
> libmpcodecs/vf_mcdeint.c:57:#include "libavutil/internal.h"
> libmpcodecs/vf_pp.c:18:#include "libavutil/internal.h"
> libmpcodecs/vf_spp.c:40:#include "libavutil/internal.h"

Actually a more complete list is in the Makefile, look for LIBAVCODEC_A
However for most of those the dependency is harder to avoid than here.