[MPlayer-cvslog] r30257 - trunk/configure

[Reimar Döffinger]

On Sun, Jan 10, 2010 at 10:58:48PM +0100, Diego Biurrun wrote:
> On Sun, Jan 10, 2010 at 02:35:09PM +0100, Reimar Döffinger wrote:
> > On Sun, Jan 10, 2010 at 02:32:38PM +0100, reimar wrote:
> > > 
> > > Log:
> > > Quote test arguments that may be empty
> > > 
> > > --- trunk/configure	Sun Jan 10 13:13:10 2010	(r30256)
> > > +++ trunk/configure	Sun Jan 10 14:32:37 2010	(r30257)
> > > @@ -3111,7 +3111,7 @@ for _ld_tmp in "$_ld_sock" "$_ld_sock -l
> > >    cc_check $_ld_tmp && inet_pton=yes && break
> > >  done
> > >  if test $inet_pton = yes ; then
> > > -  test $_ld_tmp && _res_comment="using $_ld_tmp"
> > > +  test "$_ld_tmp" && _res_comment="using $_ld_tmp"
> > >    def_inet_pton='#define HAVE_INET_PTON 1'
> > >  fi
> > >  echores "$inet_pton"
> > > @@ -3130,7 +3130,7 @@ for _ld_tmp in "$_ld_sock" "$_ld_sock -l
> > >    cc_check $_ld_tmp && inet_aton=yes && break
> > >  done
> > >  if test $inet_aton = yes ; then
> > > -  test $_ld_tmp && _res_comment="using $_ld_tmp"
> > > +  test "$_ld_tmp" && _res_comment="using $_ld_tmp"
> > 
> > On second thought, this still looks wrong. A proper fix is welcome.
> 
> ! test -z

Hm, it might actually be correct as-is.
There is test -n but it is supposedly equivalent to just test...