[MPlayer-cvslog] r30170 - trunk/libaf/af_format.h

[bamiaux]

Hi Reimar,

Nope, this patch doesn't work.
I'll try to know why later.

Bye

On 10/01/10 22:16, Reimar Döffinger wrote:
> Before AC3 was implicitly AF_FORMAT_8BIT, so no, I can not at all agree
> that it was cleaner.
> Looking at the hwac3 code should show clearly that SPDIF AC3 is a format
> with a 16-bit "base size".
> Please try this change, but if it helps I think they did something really stupid...
> Oh, and please try what happes if you set mBitsPerChannel to 0, because
> contrary to 8 that would make at least some sense (though it might all
> be due to the rather bogus ao->packetSize = inDesc.mBytesPerPacket = inDesc.mBytesPerFrame
> calculation ao_coreaudio uses)...
> Index: libao2/ao_coreaudio.c
> ===================================================================
> --- libao2/ao_coreaudio.c	(revision 30258)
> +++ libao2/ao_coreaudio.c	(working copy)
> @@ -349,6 +349,8 @@
>   #if HAVE_BIGENDIAN
>           inDesc.mFormatFlags |= kAudioFormatFlagIsBigEndian;
>   #endif
> +        // For some reason we only get noise if the set mBitsPerChannel to 16 for AC3
> +        inDesc.mBitsPerChannel=8;
>       }
>       else if ((format&  AF_FORMAT_END_MASK) == AF_FORMAT_BE)
>           inDesc.mFormatFlags |= kAudioFormatFlagIsBigEndian;