[MPlayer-cvslog] r30182 - in trunk: Makefile configure libvo/matrixview.c libvo/matrixview.h libvo/matrixview_font.h libvo/video_out.c libvo/vo_matrixview.c

[The Wanderer]

On 01/04/2010 08:16 AM, Reimar Döffinger wrote:

> On Mon, Jan 04, 2010 at 02:07:38PM +0100, Diego Biurrun wrote:

>>> Can we have some file like "licenseheader.txt" or such in
>>> MPlayer? So we can just cat that in front without risk of copying
>>> from the only file that has a bad/outdated/whatever one?
>> 
>> I have fixed all license headers already, so there is no risk of
>> copying a wrong one. Of course, some files still lack license
>> headers. Would it be enough to add license headers to all files?
> 
> Well,
> cat licenseheader file.c > newfile.c
> is still a bit less effort than having to use copy-and-paste, but
> it's not really relevant (it might be if ever e.g. the FSF moves
> again, because there's some risk we will miss to fix at least some
> license headers).

Not that much risk, with a combination of find and sed:

find mplayer/ -type f | grep -v '\.svn' | tr '\n' '\000' | xargs -0 sed 
-i 's at oldaddress@newaddress at g'

svn diff > fsf-moved.diff

And then check the patch to make sure it includes only changes we want.
(It would probably be possible to shorten the pipeline quite a bit, by
use of 'find -prune', but I've never been able to make that work
reliably the way I need it to.)

> Just thinking of ways to reduce my aversion to license headers :-)

I'm not that fond of them myself, for one main reason: it feels way too
much like the same kind of mistake as code duplication. Still, I can
recognize some of the arguments for why they're necessary.

-- 
       The Wanderer, technically still here

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.