[MPlayer-cvslog] r30597 - in trunk/libmpcodecs: ad_liba52.c ad_realaud.c vd_ffmpeg.c vd_ijpg.c vd_realvid.c vd_xanim.c vf_2xsai.c

[Diego Biurrun]

On Tue, Feb 16, 2010 at 09:39:57PM +0300, Yuriy Kaminskiy wrote:
> On 16.02.2010 19:16, diego wrote:
> > 
> > Log:
> > Mark functions not used outside of their files as static.
> > 
> > --- trunk/libmpcodecs/ad_realaud.c	Tue Feb 16 16:03:03 2010	(r30596)
> > +++ trunk/libmpcodecs/ad_realaud.c	Tue Feb 16 17:16:42 2010	(r30597)
> > @@ -41,12 +41,14 @@ static const ad_info_t info =  {
> >  
> >  LIBAD_EXTERN(realaud)
> >  
> > -void *__builtin_new(unsigned long size) {
> > +static void *__builtin_new(unsigned long size)
> > +{
> >  	return malloc(size);
> >  }
> >  
> >  // required for cook's uninit:
> > -void __builtin_delete(void* ize) {
> > +static void __builtin_delete(void* ize)
> > +{
> >  	free(ize);
> >  }
> >  
> 
> I'm not sure, and cannot test, but I think this is wrong. __builtin_new/delete
> seems exported for use in {14_4,28_8}.so.6.0, not internally used by
> ad_readaud.c at all.

You are right, thanks for noticing, fixed.

> > --- trunk/libmpcodecs/vd_xanim.c	Tue Feb 16 16:03:03 2010	(r30596)
> > +++ trunk/libmpcodecs/vd_xanim.c	Tue Feb 16 17:16:42 2010	(r30597)
> > @@ -335,7 +335,7 @@ static int xacodec_query(sh_video_t *sh,
> >      }
> >  }
> >  
> > -void XA_Print(char *fmt, ...)
> > +static void XA_Print(char *fmt, ...)
> Same here, exported for use in codecs (some function below certainly used in
> codecs, for some I don't see imports in xanimdlls-20040626.tar.bz2, not sure
> about other version/arch/...)

Yes.  I'm starting to pick up some nm skills now :)

> > -void XA_dummy(void)
> > +static void XA_dummy(void)
> not sure

I'm not sure either, nm -D does not show it for the set of XAnim codecs
that I have..

> > -void XA_2x2_OUT_1BLK_Convert(unsigned char *image_p, unsigned int x, unsigned int y,
> > +static void XA_2x2_OUT_1BLK_Convert(unsigned char *image_p, unsigned int x, unsigned int y,
> not sure

All the _Convert functions appear not to be used directly..

Diego