[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

Diego Biurrun diego at biurrun.de
Wed Aug 25 14:22:19 CEST 2010


On Wed, Aug 25, 2010 at 12:09:33PM +0200, Nicolas George wrote:
> 
> Note that after just one fumbled commit, I do not consider myself entitled
> to commit patches without approval, even trivial cosmetic patches.

I disagree.  Be more careful the next time around, but keep on working.

> --- a/eosd.c
> +++ b/eosd.c
> @@ -26,15 +26,19 @@
>  
> +#if CONFIG_ASS
>  static ASS_Renderer *ass_renderer;
>  int prev_visibility;
> +#endif
>  
> +#if CONFIG_ASS
>  void eosd_ass_init(ASS_Library *ass_library)
>  {
>      ass_renderer = ass_renderer_init(ass_library);
>      if (!ass_renderer) return;
>      ass_configure_fonts(ass_renderer);
>  }
> +#endif

These ifdefs should of course be merged.

> --- a/eosd.h
> +++ b/eosd.h
> @@ -25,9 +25,11 @@
>  
> +#ifdef CONFIG_ASS
>  void eosd_ass_init(ASS_Library *);
> +#endif

This #ifdef is unnecessary.

Diego


More information about the MPlayer-cvslog mailing list