[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

[Nicolas George]

L'octidi 8 fructidor, an CCXVIII, Reimar Döffinger a écrit :
> Why don't you just use "struct ass_image" in the header?

Of course, I should have thought of it. I did that. It also required quite a
few #ifdef for the ASS-specific code, but it fixes building with
--without-ass.

The eosd-dynamic patch, when adapted, should reduce the number of #ifdef
drastically. That is one of the points of it.

> Then you can just also add a
> struct ass_image;
> before and it will compile fine without having to know the
> internals of ASS_Image.
> This is something that should stay like this also for the EOSD,
> the struct internals should stay opaque as much as possible,
> that's always good design.
> On the other hand, casts are always bad design, and in this case
> you can't in any way guarantee it will work with external libass,
> so I don't think that should be done.

I meant it as a temporary measure, but your way is better, of course.

On the other hand, I do not think this particular structure can stay opaque:
it is filled and updated by clients and read by renderers, so both need to
know its internals. I'll keep that consideration in mind though.

Attached the patch to fix ASS-less build.

Note that after just one fumbled commit, I do not consider myself entitled
to commit patches without approval, even trivial cosmetic patches.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-00-noass-20100825-1154.diff
Type: text/x-diff
Size: 1998 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20100825/5305cd97/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20100825/5305cd97/attachment.pgp>