[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

Diego Biurrun diego at biurrun.de
Tue Aug 24 03:16:54 CEST 2010


On Mon, Aug 23, 2010 at 09:22:03PM +0200, cigaes wrote:
> 
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ trunk/eosd.c	Mon Aug 23 21:22:03 2010	(r32009)
> @@ -0,0 +1,70 @@
> +void eosd_ass_init(ASS_Library *ass_library)
> +{
> +    ass_renderer = ass_renderer_init(ass_library);
> +    if (!ass_renderer) return;

Please place the statement on the next line.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ trunk/eosd.h	Mon Aug 23 21:22:03 2010	(r32009)
> @@ -0,0 +1,33 @@
> +
> +void eosd_init(vf_instance_t *);
> +
> +void eosd_configure(mp_eosd_res_t *, int);
> +ASS_Image *eosd_render_frame(double, int *);
> +void eosd_uninit(void);
> +
> +void eosd_ass_init(ASS_Library *);

I consider leaving out the variable names bad style.

Diego


More information about the MPlayer-cvslog mailing list