[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

[Ivan Kalvachev]

On 8/23/10, Nicolas George <nicolas.george at normalesup.org> wrote:
> Le sextidi 6 fructidor, an CCXVIII, cigaes a écrit :
>> Forgot to svn add those two files.
>>
>> Added:
>>    trunk/eosd.c
>>    trunk/eosd.h
>
> My very first commit, aid I messed it up :(
>
> I am so terribly sorry. I committed the second bit in a hurry, so as not to
> leave the repository in a broken state. Now I am looking for ways to fix the
> history.

That's not even half of it. ;)

There are user reports about breaking build.
The eosd.h uses ASS_Image typedef. There is no include header that
defines it in the eosd.h  (aka probably breaks `make checkheaders`).
The rule says a header should include all headers needed to define the
stuff in the said header, aka it should be able to work on its own.
There is a tricky situation here, for the case when libass is not
enabled and (in future case when internal libass is removed) even
missing.

Well, having crash course in development is not nice, just don't give up.
Best Regards.