[MPlayer-cvslog] r29730 - in trunk: cfg-common-opts.h mencoder.c mplayer.c

[The Wanderer]

On 09/28/2009 10:49 AM, Reimar Döffinger wrote:

> On Mon, Sep 28, 2009 at 10:13:29AM -0400, The Wanderer wrote:
> 
>> On 09/28/2009 07:32 AM, reimar wrote:
>> 
>>> Author: reimar
>>> Date: Mon Sep 28 13:32:27 2009
>>> New Revision: 29730
>>> 
>>> Log:
>>> Add a -nosub option that allows disabling auto-selected subtitles as e.g. the
>>> mkv demuxer supports.
>> 
>> Could this be extended (or, for that matter, another option be
>> added) to allow disabling previously-explicitly-selected subtitles?
> 
> If this options doesn't do that, please provide a bug report (well,
> actually just testing and telling me the result should be ok).

It doesn't.

>> This option seems like it could be the correct one to disable
>> subtitles that way, syntactically speaking, but from a quick test
>> it doesn't do that. Is there a reason why it shouldn't?
> 
> Probably that I missed a dvdsub_id < 0 that should be a dvdsub_id ==
> -1 or that there is some other buggy code that makes -slang override
> -sid. For that later case, try if -sid 200 or so reliably disables 
> subtitles.

That would be a reason why it doesn't, not a reason why it shouldn't -
which means that you probably do agree that it should, which means I'm
glad. ^_^

I'm not sure how much is enough to judge "reliably", but I can confirm
that the quick-to-hand disc I was testing with this morning gets its
(English) subtitles with '-nosub' but not with '-sid 200' or '-slang
ja'.

I have access to a fair number of DVDs, though how many (from different
sources, i.e. not just part of the same series collection) with English
subtitles I'm not entirely sure. How much testing would you consider
enough to be reliable?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.