[MPlayer-cvslog] r29673 - trunk/etc/codecs.conf

[compn]

On Sat, 12 Sep 2009 23:39:49 +0200, Reimar Döffinger wrote:
>
>On Sat, Sep 12, 2009 at 05:33:17PM -0400, compn wrote:
>> On Sat, 12 Sep 2009 18:49:11 +0200 (CEST), compn wrote:
>> >add kega video binary codec for fourcc kgv1
>> 
>> arrg, this works on win32, but fails on linux
>> anyone with loader experience want to help me out?
>> 
>> Called unk_??2 at YAPAXI@Z
>> 
>> http://samples.mplayerhq.hu/V-codecs/kgv1.avi
>> http://samples.mplayerhq.hu/drivers32/new/KGV1-VFW.dll
>
>
>> External func MSVCR80.dll:??2 at YAPAXI@Z
>> External func MSVCR80.dll:??3 at YAXPAX@Z
>> Called unk_??2 at YAPAXI@Z
>
>These are the new and delete operators. What they are doing in the _C_
>runtime lib? Well, Microsoft seems to always have hated pure C...
>Obviously at least for new we'd need an implementation otherwise it's no
>surprise the code can't really work.
>The only problem is, those are defined at line 5026 of win32.c, so teh
>question is why is the stub for unknown functions called here??
>Maybe this helps?:
>Index: win32.c
>===================================================================
>--- win32.c     (revision 29672)
>+++ win32.c     (working copy)
>@@ -2323,7 +2323,8 @@
> 
>     if (strcasecmp(name, "comdlg32.dll") == 0 || strcasecmp(name, "comdlg32") == 0)
>        return MODULE_HANDLE_comdlg32;
>-    if (strcasecmp(name, "msvcrt.dll") == 0 || strcasecmp(name, "msvcrt") == 0)
>+    if (strcasecmp(name, "msvcrt.dll") == 0 || strcasecmp(name, "msvcrt") == 0 ||
>+        strcasecmp(name, "msvcr80.dll") == 0 || strcasecmp(name, "msvcr80") == 0)
>        return MODULE_HANDLE_msvcrt;
>     if (strcasecmp(name, "ole32.dll") == 0 || strcasecmp(name, "ole32") == 0)
>        return MODULE_HANDLE_ole32;

user reports patch does not work.
on windows, the codec fails to load if msvcr80.dll is missing.
that should probably go into a comment on codecs.conf.

i think you also have to patch this part, why its split up i dont
know... that file needs a bit of cleanup! :)

line 2401:
    case MODULE_HANDLE_msvcrt:
	result=LookupExternalByName("msvcrt.dll", name); break;

-compn