[MPlayer-cvslog] r29839 - trunk/mplayer.c

[Uoti Urpala]

On Sat, 2009-11-07 at 19:19 +0100, Michael Niedermayer wrote:
> On Fri, Nov 06, 2009 at 09:27:20PM +0200, Uoti Urpala wrote:
> > Stuff like this would be better combined into one commit together with
> > other trivial changes. 
> 
> That is your oppinon, its for example not my oppinion and i would suspect

Some things are purely matters of opinion with no objective "right" way.
This however is not one of them. Note that I gave actual reasons instead
of just saying "it's my opinion".


> Of course one could commit things together, its not the end of the world
> but i thought as you have your private fork already you would apply your
> ideas to it and the rest of the world would apply their ideas to their
> stuff.

You should realize that in most cases where our development preferences
differ, it's my way that is much closer to the "rest of the world". Your
preferences are often peculiarities of old MPlayer/FFmpeg developers,
and have not gained much popularity elsewhere for a reason.