[MPlayer-cvslog] r29848 - in trunk: cfg-common.h command.c configure libmpcodecs/dec_teletext.clibmpcodecs/dec_teletext.h libmpdemux/demuxer.h mpcommon.c stream/tv.c stream/tv.h stream/tvi_dshow.cstream/tvi_v4l.c...

[Reimar Döffinger]

On Sat, Nov 07, 2009 at 12:59:57PM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
> > > -    if test "$_tv_v4l2" = yes || test "$_v4l" = yes || test "$_tv_dshow" =
> > > yes; then
> > > +    if test "$_tv_v4l2" = yes || test "$_v4l" = yes || test "$_tv_dshow" =
> > > yes || test "$_dvbin" = yes; then
> > 
> > That's nonsense, somebody might want to play a captured DVB file with
> > teletext, so it should be always enabled (unless explicitly disabled) IMO.
> 
> Or should we remove CONFIG_TV_TELETEXT completely, like this we can get rid of
> the ugly ifdef in dec_teletext.h?

I personally wouldn't mind, and I guess it is not much code so it
shouldn't be an issue, but I don't know.