[MPlayer-cvslog] [propchange]: r29324 - svn:log

[Diego Biurrun]

On Tue, May 26, 2009 at 10:11:41AM -0400, compn wrote:
> On Tue, 26 May 2009 15:50:10 +0200, Diego Biurrun wrote:
> >On Tue, May 26, 2009 at 03:46:48PM +0200, compn wrote:
> >> 
> >> --- old property value
> >> +++ new property value
> >> @@ -1,3 +1,2 @@
> >> -add dvh1 and Mp42, fixes:
> >> -unknown_audio_codec.avi
> >> -dvh1_sample_truncated.avi
> >> +add dvh1 to ffdv, fixes dvh1_sample_truncated.avi
> >> +and Mp42 to ffmp42, fixes unknown_audio_codec.avi
> >
> >"add foo to bar" is no better, just mention that the four-letter
> >abbreviation is a fourcc.  It's not immediately obvious that ffdv is not
> >a fourcc in this list.
> 
> i dont mind changing it, but it would be nice if you told me (or fixed
> it yourself) instead of making me guess as to what you want.

The message should be explanatory and self-contained.  A reasonably
competent person should be able to understand it without extra
information.  That means without looking at the actual diff.

Four-letter acronyms can mean any number of things in different
contexts.  Do not expect all readers of this commit message to know them
by heart (and be able to immediately tell which is which here).

> is this what you want?
> +add dvh1 fourcc to ffdv codec, fixes dvh1_sample_truncated.avi
> +and Mp42 fourcc to ffmp42 codec, fixes unknown_audio_codec.avi

This is sufficient.  Notice how it provides much more information with
just a few more words.

Diego