[MPlayer-cvslog] r29290 - trunk/xvid_vbr.c

[Diego Biurrun]

On Tue, May 12, 2009 at 12:50:17PM -0400, Reynaldo H. Verdejo Pinochet wrote:
> 
> Diego Biurrun wrote:
> > 
> > What made you think it might be a good idea to do this file-by-file?
> 
> Oh, I was just trying out an small regexp. Being code I not maintain
> though, I'd rather do it this way. You can obviously revert if you
> don't like this degree of granularity. Assuming your pre-commit hook
> (if it is in place already) allows you to do that without choking.
> 
> Now, I, in return; would like to hear from you why its a bad idea
> to commit trivial, self-contained changes to files you don't maintain
> in file rounds though. Just for the enlightenment.

It spams the list and the logs with useless commits and creates useless
clutter that makes the lists and logs unwieldy.

It's also not really logically separated.  Deleting trailing whitespace
from one or 10 files is one action, not 10 separate actions.

Diego