[MPlayer-cvslog] r28680 - trunk/libvo/vo_xvmc.c

[Diego Biurrun]

On Tue, Feb 24, 2009 at 03:25:43PM +0100, Diego Biurrun wrote:
> On Sat, Feb 21, 2009 at 12:46:24AM +0100, iive wrote:
> > 
> > Log:
> > Turn all remaining printf() into mp_msg().
> > Try to set appropriate levels for them.
> > 
> > --- trunk/libvo/vo_xvmc.c	Sat Feb 21 00:18:28 2009	(r28679)
> > +++ trunk/libvo/vo_xvmc.c	Sat Feb 21 00:46:24 2009	(r28680)
> > @@ -226,58 +226,59 @@ return -1;//fail
> >  //print all info needed to add new format
> >  static void print_xvimage_format_values(XvImageFormatValues *xifv){
> >      int i;
> > +    const msgl=MSGL_DBG4;
> >  
> > -    printf("Format_ID = 0x%X\n",xifv->id);
> > +    mp_msg(MSGT_VO,msgl,"Format_ID = 0x%X\n",xifv->id);
> 
> This looks rather weird to me and generates the following warning:
> 
> libvo/vo_xvmc.c: In function 'print_xvimage_format_values':
> libvo/vo_xvmc.c:229: warning: type defaults to 'int' in declaration of 'msgl'

Here is a patch that just uses search and replace to fix this.
An alternative would be a #define, but I don't really see a need
for indirection here.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvmc_dgb4.diff
Type: text/x-diff
Size: 5098 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20090314/c50142ca/attachment.diff>