[MPlayer-cvslog] r28816 - trunk/libass/ass_bitmap.c

[Reimar Döffinger]

On Thu, Mar 05, 2009 at 09:36:35PM +0100, greg wrote:
> Author: greg
> Date: Thu Mar  5 21:36:35 2009
> New Revision: 28816
> 
> Log:
> Hack: half-merge glyph border with outline to avoid ugly anti-aliasing
> in certain situations.
> 
> Modified:
>    trunk/libass/ass_bitmap.c
> 
> Modified: trunk/libass/ass_bitmap.c
> ==============================================================================
> --- trunk/libass/ass_bitmap.c	Thu Mar  5 21:25:54 2009	(r28815)
> +++ trunk/libass/ass_bitmap.c	Thu Mar  5 21:36:35 2009	(r28816)
> @@ -243,7 +243,7 @@ static bitmap_t* fix_outline_and_shadow(
>  			unsigned char c_g, c_o;
>  			c_g = g[x];
>  			c_o = o[x];
> -			o[x] = (c_o > c_g) ? c_o : 0;
> +			o[x] = (c_o > c_g) ? c_o - (c_g/2) : 0;

IMO please document such hacks also directly in the code where they are,
maybe including a hint what a proper fix would be.