[MPlayer-cvslog] r29447 - trunk/stream/realrtsp/real.c

[Ivan Kalvachev]

On 7/27/09, uau <subversion at mplayerhq.hu> wrote:
> Author: uau
> Date: Mon Jul 27 18:53:48 2009
> New Revision: 29447
>
> Log:
> stream/realrtsp/real.c: Fix integer overflow
>
> Pointed-out-by: tixxDZ <tixxdz at gmail dot com> - DZCORE Labs, Algeria
>
> Modified:
>    trunk/stream/realrtsp/real.c
>
> Modified: trunk/stream/realrtsp/real.c
> ==============================================================================
> --- trunk/stream/realrtsp/real.c	Mon Jul 27 08:47:41 2009	(r29446)
> +++ trunk/stream/realrtsp/real.c	Mon Jul 27 18:53:48 2009	(r29447)
> @@ -386,6 +386,8 @@ int real_get_rdt_chunk(rtsp_t *rtsp_sess
>      return (n <= 0) ? 0 : n;
>    }
>    rmff_dump_pheader(&ph, *buffer);
> +  if (size < 12)
> +      return 0;
>    size-=12;
>    n=rtsp_read_data(rtsp_session, (*buffer)+12, size);

I suspect that this fix is incomplete as MPlayer code is a little bit
more complicated than the original and VLC one where this patch
originates.