[MPlayer-cvslog] r29411 - trunk/DOCS/tech/svn-howto.txt
tempn at twmi.rr.com
Sun Jul 5 02:10:46 CEST 2009
On Sun, 5 Jul 2009 02:36:30 +0300, Ivan Kalvachev wrote:
>On 7/4/09, diego <subversion at mplayerhq.hu> wrote:
>> Author: diego
>> Date: Sat Jul 4 15:26:51 2009
>> New Revision: 29411
>> Add a section about handling external code to the policy.
>> Modified: trunk/DOCS/tech/svn-howto.txt
>> --- trunk/DOCS/tech/svn-howto.txt Fri Jul 3 18:10:58 2009 (r29410)
>> +++ trunk/DOCS/tech/svn-howto.txt Sat Jul 4 15:26:51 2009 (r29411)
>> @@ -315,6 +315,15 @@ II. POLICY / RULES:
>> IRC is good for quick discussions, but nobody is there 24/7.
>> +14. MPlayer contains some external code that is partly patched, partly
>> + verbatim (see Copyright for details). This code should not be modified
>> + unless there is a very good reason. Much of it is maintained upstream.
>> + We should be good open source citizens, submit our fixes upstream and
>> + the differences as small as possible.
>> + If you have to modify external code, do not forget to update the diff
>> + with our local changes.
>I oppose this commit.
>1. It is not discussed in advance. What gives you right to make up
>rules on your own, because you think something is good idea?
>2. This code is copied into mplayer repository especially to give us
>more freedom to thinker with it. It is absurd to turn this into policy
erm probably agree w/ iive, lets get a project leader and do this
correctly... work on patching mp3lib/libmpg123 to upstream, instead of
playing with the rules.
see this thread: [MPlayer-dev-eng] mpg123 / mp3lib 64bit SSE code
you suggested that the libmpg123 guys should merge with ffmpeg?
they refused. so what now? should mplayer send patches upstream or work
on ffmp3 instead?
More information about the MPlayer-cvslog