[MPlayer-cvslog] r28360 - in trunk: Makefile mencoder.c mpcommon.c mpcommon.h mplayer.c version.sh

[Diego Biurrun]

On Sun, Jan 25, 2009 at 11:54:53PM +0100, Aurelien Jacobs wrote:
> diego wrote:
> 
> > Log:
> > Factorize print_version().
> > 
> > [...]
> > @@ -24,6 +28,47 @@ ass_track_t* ass_track = 0; // current t
> >  
> > +#if HAVE_MMX
> > +    mp_msg(MSGT_CPLAYER,MSGL_V," MMX");
> > +#endif
> > +#if HAVE_MMX2
> > +    mp_msg(MSGT_CPLAYER,MSGL_V," MMX2");
> > +#endif
> > +#if HAVE_3DNOW
> > +    mp_msg(MSGT_CPLAYER,MSGL_V," 3DNow");
> > +#endif
> > +#if HAVE_3DNOWEX
> > +    mp_msg(MSGT_CPLAYER,MSGL_V," 3DNowEx");
> > +#endif
> > +#if HAVE_SSE
> > +    mp_msg(MSGT_CPLAYER,MSGL_V," SSE");
> > +#endif
> > +#if HAVE_SSE2
> > +    mp_msg(MSGT_CPLAYER,MSGL_V," SSE2");
> > +#endif
> > +    mp_msg(MSGT_CPLAYER,MSGL_V,"\n");
> > +#endif /* RUNTIME_CPUDETECT */
> > +#endif /* ARCH_X86 */
> > +}
> 
> Unrelated to this commit, but this could be written nicer, smaller,
> more readable:
> 
> if (HAVE_MMX)    mp_msg(MSGT_CPLAYER,MSGL_V," MMX"  );
> if (HAVE_MMX2)   mp_msg(MSGT_CPLAYER,MSGL_V," MMX2" );
> if (HAVE_3DNOW)  mp_msg(MSGT_CPLAYER,MSGL_V," 3DNow");

Done, thanks for the hint.

Diego