[MPlayer-cvslog] r28037 - trunk/cpudetect.c

[Guillaume POIRIER]

Hello,

On Thu, Jan 15, 2009 at 11:54 AM, Attila Kinali <attila at kinali.ch> wrote:
>
> On Tue, 25 Nov 2008 19:36:50 +0100 (CET)
> cehoyos <subversion at mplayerhq.hu> wrote:
>
> > Modified: trunk/cpudetect.c
> > ==============================================================================
> > --- trunk/cpudetect.c (original)
> > +++ trunk/cpudetect.c Tue Nov 25 19:36:50 2008
> > @@ -57,10 +57,17 @@ static int has_cpuid(void)
> >       long a, c;
> >
> >  // code from libavcodec:
> > +#ifdef ARCH_X86_64
>
> This line breaks compilation on x86 as ARCH_X86_64 is always defined,
> either as 1 or 0.

Worse, it break all non x86-64 builds! PPC64 build is broken!

Guillaume
--
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Natalie Wood  - "The only time a woman really succeeds in changing a
man is when he is a baby."