[MPlayer-cvslog] r28546 - in trunk/libvo: video_out.c video_out.h vo_direct3d.c vo_xv.c vo_xvmc.c

[Reimar Döffinger]

On Sun, Feb 22, 2009 at 09:14:09AM -0500, The Wanderer wrote:
> reimar wrote:
> > Author: reimar
> > Date: Thu Feb 12 18:40:53 2009
> > New Revision: 28546
> > 
> > Log:
> > Add a calc_src_dst_rects that calculates from window size, panscan etc.
> > which part of the video source must be scaled onto which part of the window.
> > Direct3D and (future) VDPAU need this, for XvMC it makes it easier to add
> > cropping support and Xv is changed to keep the diff to XvMC small.
> 
> This revision broke fullscreen (and possibly some scaled non-fullscreen)
> playback for me.
> 
> Prior to this, I get what appears to be normal, correct playback.
> 
> With this revision and after, when using either '-fs' or '-xy (my
> monitor X resolution)', the top of the image is visibly further down
> from the top of the screen than it should be, and the bottom of the
> image is visibly cut off by the bottom of the screen - by enough to cut
> off all subtitles in at least one case I tested, and by more with '-fs'
> than with the other option. The left edge of the image may also be
> shifted right similarly, but because of the aspect ratios I have
> immediately available (320x240 files, 2560x1600 monitor) it's difficult
> to tell.
> 
> This behaviour occurs at least with -vo {xv,vdpau}, I haven't tried
> others yet.
> 
> I don't see any obvious differences between the console output of the
> two versions.
> 
> Any suggestions on how to pin down the cause?

Not really, I just tried again with a 352x288 video on a 1680x1050
screen, using latest NVidia drivers. I also added -aspect 2 and -aspect
0.7 and the video is exactly (well, as much as I can tell) centered for
all cases.
-xy does not even enable the code that creates borders, so if you use
only -xy (not -fs or switched to fullscreen otherwise) I can't see how
this should be possible...
Have you checked that there are not some custom patches applied that
might cause issues?