[MPlayer-cvslog] r28370 - in trunk: Makefile configure cpudetect.cliba52/imdct.c liba52/imdct_3dnow.hliba52/liba52_changes.diff liba52/srfftp_3dnow.h libaf/af.hlibmpcodecs/vf_filmdint.c libmpcodecs/vf_tfields.c ...

[Diego Biurrun]

On Mon, Feb 09, 2009 at 11:39:20AM +0200, Ivan Kalvachev wrote:
> On 2/9/09, Diego Biurrun <diego at biurrun.de> wrote:
> > On Mon, Feb 09, 2009 at 03:06:22AM +0200, Ivan Kalvachev wrote:
> >> On 1/26/09, Diego Biurrun <diego at biurrun.de> wrote:
> >> > On Mon, Jan 26, 2009 at 11:52:05PM +0800, Zuxy Meng wrote:
> >> >> "diego" <subversion at mplayerhq.hu>
> >> >> 写入消息新闻:20090126092954.4AE273B0EB at natsuki.mplayerhq.hu...
> >> >> >
> >> >> > Log:
> >> >> > HAVE_3DNOW --> HAVE_AMD3DNOW
> >> >>
> >> >> Just curious, but why?
> >> >
> >> > Sync with FFmpeg.
> >>
> >> Guess who added it this way into FFmpeg. ;)
> >
> > Shell variable names are not allowed to start with numbers, same as in C.
> 
> "HAVE_3DNOW" doesn't start with number.
> 
> Actually for that exact reason all variables in mplayer configure
> start with _<something> so _3dnow is perfectly valid.

amd3dnow is a perfectly acceptable variable name.

> Instead of making everything else fit into square hole,
> you should have fixed the shortcoming in ffmpeg configure.
> 
> But I guess it is easier to mangle all of mplayer,
> than send patch to mans.

It's easier to continue working on either configure than wasting time
flaming with you.  That's what I will do.  Case closed.

Diego