[MPlayer-cvslog] r28468 - trunk/libvo/vo_direct3d.c

[Reimar Döffinger]

On Thu, Feb 05, 2009 at 02:05:45PM +0100, Diego Biurrun wrote:
> - Do not indirectly describe what your commit does and talk about your
>   commit as an entity in your commit message.  Just say it directly.
>   I'm not saying "This email is supposed to teach you to write better
>   commit messages." because this is an email and it is obvious that you
>   know this is an email.  So instead of "This patch/commit unifies.."
>   you cut out the middlemen and say "Unify...".

I'd like to point out that the other commit was "right" :-) .

> - DOCS/tech/svn-howto.txt has a short paragraph about changing commit
>   messages.

Hm, I think he is using TortoiseSVN, but I think it should be easy
enough to find out how to do it with that.
I think the commit message was not that bad and not too important
anyway, but anyway it would be a good opportunity to test how you can change
them.