[MPlayer-cvslog] r28468 - trunk/libvo/vo_direct3d.c

[Diego Biurrun]

On Thu, Feb 05, 2009 at 10:06:10AM +0100, gogothebee wrote:
> 
> Log:
> This patch unifies info/error messages
> to a common style: <vo_direct3d> in the beginning of each message and "." at the end. Messages are shorter/more descriptive.

Congrats for your first commit from me as well.

Now a few words about your commit message:

- Please keep lines below 80 characters where reasonable.
- A patch is not the same thing as a commit :)
- Do not indirectly describe what your commit does and talk about your
  commit as an entity in your commit message.  Just say it directly.
  I'm not saying "This email is supposed to teach you to write better
  commit messages." because this is an email and it is obvious that you
  know this is an email.  So instead of "This patch/commit unifies.."
  you cut out the middlemen and say "Unify...".
- DOCS/tech/svn-howto.txt has a short paragraph about changing commit
  messages.

Diego