[MPlayer-cvslog] r29541 - trunk/libaf/reorder_ch.c

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Aug 19 21:09:14 CEST 2009


On Wed, 2009-08-19 at 14:10 -0400, Jason Tackaberry wrote:
> On Wed, 2009-08-19 at 14:08 -0400, Jason Tackaberry wrote:
> > On Wed, 2009-08-19 at 19:49 +0200, Diego Biurrun wrote:
> > > Please do not use third person in commit messages.  It sounds awkward
> > > and is inconsistent with most other commit messages.
> > 
> > Understood.
> 
> But note r29475 :P

There the third person part was used in an additional description of the
change. "Does X" alone is awkward; "Do X.\n ... This also fixes ABC."
can be OK.



More information about the MPlayer-cvslog mailing list