[MPlayer-cvslog] r29132 - in trunk: Makefile libaf/af.c libaf/af_bs2b.c

[Andrew Savchenko]

Hi,

On Friday 03 April 2009, Reimar Döffinger wrote:
> On Thu, Apr 02, 2009 at 09:01:57PM +0200, bircoph wrote:
> > +#ifdef WORDS_BIGENDIAN
> > +                af->play = play_fbe;
> > +#else
> > +                af->play = play_fle;
> > +#endif //WORDS_BIGENDIAN
>
> Sorry for noticing only now, but what "nonsense" is that with
> little/bigendian float?
> It's maybe more theoretical, but the endianness of float values
> is not necessarily the same as for int values, and
> WORDS_BIGENDIAN only covers the int values (in that light, maybe
> even AF_FORMAT_FLOAT_NE itself is a bit questionable).
> It might ease portable use of the bs2b library if it provided a
> function to process samples in native float format, particularly
> should there be any systems in existence that use
> "middle-endian" for floats. 

And this function was provided. My goal was to omit one more PLAY() 
function. Fixed, I wasn't aware of mixed-endian systems.

BTW, in current svn head of libbs2b (tagged as ready to 3.0.0 
release) API was changed. New patch will be sent soon.


-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20090403/5c8da21f/attachment-0001.pgp>